Priority fees on EVMs (EIP-1559) #16342

enjojoy · 2025-01-14T10:07:16Z

Description

Added priority fee for all EVM chains except BSC and Ethereum classic (not supported)

Bsc has base fee always at 0, so it's needed to adjust the logic for bsc separately.

Refactored Fee component

Connect part of this PR was moved to #17156

Related Issue

Resolve #16438

Screenshots:

github-actions · 2025-01-14T10:11:34Z

🚀 Expo preview is ready!

Project → trezor-suite-preview
Platforms → android, ios
Scheme → trezorsuitelite
Runtime Version → 26
More info

Learn more about 𝝠 Expo Github Action

packages/blockchain-link-types/src/responses.ts

packages/connect/src/api/blockchainEstimateFee.ts

packages/connect/src/types/api/blockchainEstimateFee.ts

suite-common/wallet-config/src/networksConfig.ts

packages/blockchain-link-types/src/responses.ts

suite-common/wallet-core/src/blockchain/blockchainThunks.ts

packages/connect/src/api/bitcoin/Fees.ts

packages/suite/src/support/messages.ts

packages/components/src/components/Card/Card.tsx

packages/suite/src/components/wallet/Fees/Fees.tsx

suite-common/wallet-utils/src/sendFormUtils.ts

suite-common/wallet-core/src/send/sendFormEthereumThunks.ts

packages/suite/src/components/wallet/Fees/FeeDetails.tsx

coderabbitai · 2025-02-03T11:00:12Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

enjojoy · 2025-02-20T17:10:40Z

I separated misc levels from bitcoin, can you please check? @marekrjpolak In the future it would make sense to separate Ethereum from misc too, I think. And then Solana when there will be priority fees as well. But for now I think this is sufficient.

vytick

a few cosmetic nits from me

packages/suite/src/components/wallet/Fees/CustomFee.tsx

vytick · 2025-02-20T21:05:21Z

packages/suite/src/components/wallet/Fees/FeeDetails.tsx

@@ -187,6 +188,7 @@ const EthereumDetails = ({
    networkType,
 }: DetailsProps) => {
    const hasSettlementLayer = !!getNetwork(symbol).settlementLayer;
+    const locale = useLocales();

    // TODO: this can be probably moved to FeeRate component


Can this be moved according to the comment? and also getFeeRate in that case

vytick · 2025-02-20T21:10:11Z

suite-common/wallet-core/src/blockchain/blockchainThunks.ts

-        if (network.networkType === 'ethereum') {
-            // NOTE: ethereum smart fees are not implemented properly in @trezor/connect Issue: https://github.com/trezor/trezor-suite/issues/5340
-            // create raw call to @trezor/blockchain-link, receive data and create FeeLevel.normal from it
+        const feeLevels: 'preloaded' | 'smart' = getNetworkFeatures(network.symbol).includes(


nit

Suggested change

const feeLevels: 'preloaded' | 'smart' = getNetworkFeatures(network.symbol).includes(

const feeLevels = getNetworkFeatures(network.symbol).includes(

vytick · 2025-02-20T21:12:16Z

suite-common/wallet-core/src/send/sendFormEthereumThunks.ts

+            maxFeePerGas: precomposedTransaction.maxFeePerGas ?? undefined,
+            maxPriorityFeePerGas: precomposedTransaction.maxPriorityFeePerGas ?? undefined,
+            gasPrice:
+                !precomposedTransaction.maxFeePerGas && precomposedTransaction.feePerByte


nit: Imo moving this ternary to separate const before const transaction = prepareEthereumTransaction({ would make it more readable

vytick · 2025-02-20T21:14:27Z

suite-common/wallet-core/src/send/sendFormEthereumUtils.ts

+    // validate if token balance is not 0 or lower than amount
+    if (
+        availableTokenBalance &&
+        (availableTokenBalance === '0' || new BigNumber(amount).gt(availableTokenBalance))


What if amount < 0 ?

vytick · 2025-02-20T21:15:57Z

suite-common/wallet-core/src/send/sendFormEthereumUtils.ts

+        feePerByte: feeLevel.feePerUnit,
+        feeLimit: feeLevel.feeLimit,
+        token,
+        bytes: 0, // TODO: calculate


why not to calculate in this PR?

PeKne

I went through the code and found no major problems. My comments are rather code-style/readability proposals.

Although it is quite a big change, so make sure that QA will test both ETH priority fees and All the other network fees (even in mobile app) thoroughly before merging this 🙏

...e/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewSummary.tsx

packages/suite/src/components/wallet/Fees/CustomFee.tsx

packages/suite/src/components/wallet/Fees/Fees.tsx

PeKne · 2025-02-21T09:30:08Z

suite-common/wallet-types/src/sendForm.ts

@@ -17,6 +17,11 @@ export interface FormState {
    setMaxOutputId?: number;
    selectedFee?: FeeLevel['label'];
    feePerUnit: string; // bitcoin/ethereum/ripple custom fee field (satB/gasPrice/drops)
+    maxPriorityFeePerGas?: string; // ethereum eip1559 only


what about moving all these new attributes to eip1559 object? That would make it more readable, especially when this type is shared for all the networks.

So e.g. FormState.maxPriorityFeePerGas would be --> FormState.eip1559.axPriorityFeePerGas etc.

What do you think?

marekrjpolak · 2025-02-21T09:51:55Z

packages/connect/src/api/bitcoin/BitcoinFees.ts

    async load(blockchain: Blockchain) {
-        if (this.coinInfo.type !== 'bitcoin') return this.loadMisc(blockchain);
+        if (this.coinInfo.type !== 'bitcoin') return undefined;


I would change the type of coinInfo received in constructor to BitcoinNetworkInfo, then we can remove this check.

Otherwise, the BitcoinFees/MiscFees separation looks good.

I think I will actually create a separate PR only for this part, this PR is already too big and it will be safer to merge it in parts.

Yes, this should be pretty uncontroversial PR.

packages/blockchain-link-types/src/responses.ts

suite-common/wallet-utils/src/sendFormUtils.ts

tomasklim requested changes Jan 16, 2025

View reviewed changes

enjojoy force-pushed the feat/priority-fees branch 13 times, most recently from 1976ef5 to 51b93d9 Compare January 17, 2025 14:40

tomasklim reviewed Jan 17, 2025

View reviewed changes

packages/blockchain-link-types/src/responses.ts Outdated Show resolved Hide resolved

tomasklim reviewed Jan 17, 2025

View reviewed changes

suite-common/wallet-core/src/blockchain/blockchainThunks.ts Outdated Show resolved Hide resolved

tomasklim reviewed Jan 17, 2025

View reviewed changes

packages/connect/src/api/bitcoin/Fees.ts Outdated Show resolved Hide resolved

packages/connect/src/api/bitcoin/Fees.ts Outdated Show resolved Hide resolved

tomasklim reviewed Jan 17, 2025

View reviewed changes

packages/connect/src/api/bitcoin/Fees.ts Outdated Show resolved Hide resolved

enjojoy force-pushed the feat/priority-fees branch 3 times, most recently from 8b615ab to a02ee59 Compare January 22, 2025 16:30

tomasklim requested changes Jan 24, 2025

View reviewed changes

enjojoy force-pushed the feat/priority-fees branch from a02ee59 to bef5516 Compare February 3, 2025 11:00

enjojoy force-pushed the feat/priority-fees branch 5 times, most recently from 9062eec to 816379a Compare February 3, 2025 16:00

enjojoy force-pushed the feat/priority-fees branch 4 times, most recently from edf2a0c to a0c530d Compare February 20, 2025 11:48

enjojoy changed the title ~~chore(suite): add priority fee network feature~~ Priority fees on EVMs (EIP-1559) Feb 20, 2025

vytick reviewed Feb 20, 2025

View reviewed changes

PeKne reviewed Feb 21, 2025

View reviewed changes

marekrjpolak reviewed Feb 21, 2025

View reviewed changes

marekrjpolak mentioned this pull request Feb 21, 2025

Separate bitcoin and misc fee levels #17156

Merged

tomasklim reviewed Feb 23, 2025

View reviewed changes

packages/blockchain-link-types/src/responses.ts Outdated Show resolved Hide resolved

packages/blockchain-link-types/src/responses.ts Outdated Show resolved Hide resolved

tomasklim reviewed Feb 24, 2025

View reviewed changes

suite-common/wallet-utils/src/sendFormUtils.ts Outdated Show resolved Hide resolved

enjojoy force-pushed the feat/priority-fees branch 13 times, most recently from 3b7cc44 to ecf33d0 Compare February 28, 2025 20:25

enjojoy added 4 commits February 28, 2025 22:01

feat(suite): add eip1559 to fees components

73307c2

fixup! feat(suite): add eip1559 to fees components

bddb38d

feat(suite): fees in send form

0c8da1f

chore(suite): wip

aad7d97

enjojoy force-pushed the feat/priority-fees branch from ecf33d0 to aad7d97 Compare March 1, 2025 00:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Priority fees on EVMs (EIP-1559) #16342

Priority fees on EVMs (EIP-1559) #16342

enjojoy commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

coderabbitai bot commented Feb 3, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

enjojoy commented Feb 20, 2025

vytick left a comment

vytick Feb 20, 2025

enjojoy Feb 24, 2025

vytick Feb 20, 2025 •

edited

Loading

vytick Feb 20, 2025

vytick Feb 20, 2025

vytick Feb 20, 2025

PeKne left a comment •

edited

Loading

PeKne Feb 21, 2025

marekrjpolak Feb 21, 2025

marekrjpolak Feb 21, 2025

enjojoy Feb 21, 2025

marekrjpolak Feb 21, 2025

	const feeLevels: 'preloaded' \| 'smart' = getNetworkFeatures(network.symbol).includes(
	const feeLevels = getNetworkFeatures(network.symbol).includes(

Priority fees on EVMs (EIP-1559) #16342

Are you sure you want to change the base?

Priority fees on EVMs (EIP-1559) #16342

Conversation

enjojoy commented Jan 14, 2025 • edited Loading

Description

Related Issue

Screenshots:

github-actions bot commented Jan 14, 2025 • edited Loading

coderabbitai bot commented Feb 3, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

enjojoy commented Feb 20, 2025

vytick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vytick Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PeKne left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

enjojoy commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vytick Feb 20, 2025 •

edited

Loading

PeKne left a comment •

edited

Loading